Uploaded image for project: 'S2Robot'
  1. S2Robot
  2. ROBOT-47

UnknownHostExceptionをシステム例外として返さないようにする

XMLWordPrintable

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor Minor
    • 0.1.0
    • Affects Version/s: None
    • Component/s: S2Robot
    • None

      UnknownHostExceptionをシステム例外として返さない方が良い。
      これは INFO レベルでログするくらいが良いと思います。

      2009-08-17 00:04:20,289 [Robot-20090817000022210-5-2] ERROR org.seasar.robot.S2RobotThread - Crawling Exception at http://aizuyaichi.nuis.jp/index.shtm
      org.seasar.robot.RobotSystemException: Failed to access http://aizuyaichi.nuis.jp/index.shtm
         at org.seasar.robot.client.http.CommonsHttpClient.doGet(CommonsHttpClient.java:382)
         at org.seasar.robot.S2RobotThread.run(S2RobotThread.java:148)
         at java.lang.Thread.run(Thread.java:619)
      Caused by: java.net.UnknownHostException: aizuyaichi.nuis.jp
         at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177)
         at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
         at java.net.Socket.connect(Socket.java:519)
         at java.net.Socket.connect(Socket.java:469)
         at java.net.Socket.<init>(Socket.java:366)
         at java.net.Socket.<init>(Socket.java:240)
         at org.apache.commons.httpclient.protocol.DefaultProtocolSocketFactory.createSocket(DefaultProtocolSocketFactory.java:80)
         at org.apache.commons.httpclient.protocol.DefaultProtocolSocketFactory.createSocket(DefaultProtocolSocketFactory.java:122)
         at org.apache.commons.httpclient.HttpConnection.open(HttpConnection.java:707)
         at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.open(MultiThreadedHttpConnectionManager.java:1361)
         at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:387)
         at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
         at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
         at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
         at org.seasar.robot.client.http.CommonsHttpClient.doGet(CommonsHttpClient.java:283)
         ... 2 more
      

      この件以外にもシステム例外でない、アクセスエラーのようなものは INFO でログにする。

            Assignee:
            shinsuke shinsuke
            Reporter:
            shinsuke shinsuke
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: